This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-271 RFC-1035 error messages #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oksana-grishchenko
requested review from
gen1us2k and
recharte
as code owners
ghost
approved these changes
Sep 14, 2023
recharte
reviewed
Sep 14, 2023
recharte
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update error messages
Problem:
EVEREST-271
Outdated error message/function names that refers to RFC-1123
Cause:
PXC imposes to follow RFC-1035 + the rule of maximum length 22.
Solution:
Update the error message and the naming in the codebase
CHECKLIST
Jira
Tests